1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE-BSD-3-Clause file.
use std::collections::{HashMap, HashSet};
use std::ffi::CString;
use std::fs::File;
use std::io::{self, Read, Seek};
use std::os::fd::{AsFd, BorrowedFd};
use std::os::unix::io::{AsRawFd, RawFd};
use std::sync::{Arc, Mutex, RwLock, Weak};
use super::statx::statx;
use super::util::{einval, is_safe_inode};
const MOUNT_INFO_FILE: &str = "/proc/self/mountinfo";
/// Type alias for mount id.
pub type MountId = u64;
pub struct MountFd {
file: File,
mount_id: MountId,
map: Weak<RwLock<HashMap<MountId, Weak<MountFd>>>>,
}
impl AsFd for MountFd {
fn as_fd(&self) -> BorrowedFd {
self.file.as_fd()
}
}
impl Drop for MountFd {
fn drop(&mut self) {
debug!(
"Dropping MountFd: mount_id={}, mount_fd={}",
self.mount_id,
self.file.as_raw_fd(),
);
// If `self.map.upgrade()` fails, then the `MountFds` structure was dropped while there was
// still an `Arc<MountFd>` alive. In this case, we don't need to remove it from the map,
// because the map doesn't exist anymore.
if let Some(map) = self.map.upgrade() {
let mut map = map.write().unwrap();
// After the refcount reaches zero and before we lock the map, there's a window where
// the value can be concurrently replaced by a `Weak` pointer to a new `MountFd`.
// Therefore, only remove the value if the refcount in the map is zero, too.
if let Some(0) = map.get(&self.mount_id).map(Weak::strong_count) {
map.remove(&self.mount_id);
}
}
}
}
/// This type maintains a map where each entry maps a mount ID to an open FD on that mount. Other
/// code can request an `Arc<MountFd>` for any mount ID. A key gets added to the map, when the
/// first `Arc<MountFd>` for that mount ID is requested. A key gets removed from the map, when the
/// last `Arc<MountFd>` for that mount ID is dropped. That is, map entries are reference-counted
/// and other code can keep an entry in the map by holding on to an `Arc<MountFd>`.
///
/// We currently have one use case for `MountFds`:
///
/// 1. Creating a file handle only returns a mount ID, but opening a file handle requires an open FD
/// on the respective mount. So we look that up in the map.
pub struct MountFds {
map: Arc<RwLock<HashMap<MountId, Weak<MountFd>>>>,
/// /proc/self/mountinfo
mount_info: Mutex<File>,
/// An optional prefix to strip from all mount points in mountinfo
mount_prefix: Option<String>,
/// Set of filesystems for which we have already logged file handle errors
error_logged: Arc<RwLock<HashSet<MountId>>>,
}
impl MountFds {
pub fn new(mount_prefix: Option<String>) -> io::Result<Self> {
let mount_info_file = File::open(MOUNT_INFO_FILE)?;
Ok(Self::with_mount_info_file(mount_info_file, mount_prefix))
}
pub fn with_mount_info_file(mount_info: File, mount_prefix: Option<String>) -> Self {
MountFds {
map: Default::default(),
mount_info: Mutex::new(mount_info),
mount_prefix,
error_logged: Default::default(),
}
}
pub fn get<F>(&self, mount_id: MountId, reopen_fd: F) -> MPRResult<Arc<MountFd>>
where
F: FnOnce(RawFd, libc::c_int, u32) -> io::Result<File>,
{
let existing_mount_fd = self
.map
// The `else` branch below (where `existing_mount_fd` matches `None`) takes a write lock
// to insert a new mount FD into the hash map. This doesn't deadlock, because the read
// lock taken here doesn't have its lifetime extended beyond the statement, because
// `Weak::upgrade` returns a new pointer and not a reference into the read lock.
.read()
.unwrap()
.get(&mount_id)
// We treat a failed upgrade just like a non-existent key, because it means that all
// strong references to the `MountFd` have disappeared, so it's in the process of being
// dropped, but `MountFd::drop()` just did not yet get to remove it from the map.
.and_then(Weak::upgrade);
let mount_fd = if let Some(mount_fd) = existing_mount_fd {
mount_fd
} else {
// `open_by_handle_at()` needs a non-`O_PATH` fd, which we will need to open here. We
// are going to open the filesystem's mount point, but we do not know whether that is a
// special file[1], and we must not open special files with anything but `O_PATH`, so
// we have to get some `O_PATH` fd first that we can stat to find out whether it is
// safe to open.
// [1] While mount points are commonly directories, it is entirely possible for a
// filesystem's root inode to be a regular or even special file.
let mount_point = self.get_mount_root(mount_id)?;
// Clone `mount_point` so we can still use it in error messages
let c_mount_point = CString::new(mount_point.clone()).map_err(|e| {
self.error_for(mount_id, e)
.prefix(format!("Failed to convert \"{mount_point}\" to a CString"))
})?;
let mount_point_fd = unsafe { libc::open(c_mount_point.as_ptr(), libc::O_PATH) };
if mount_point_fd < 0 {
return Err(self
.error_for(mount_id, io::Error::last_os_error())
.prefix(format!("Failed to open mount point \"{mount_point}\"")));
}
// Check the mount point has the expected `mount_id`.
let st_mode = self.validate_mount_id(mount_id, &mount_point_fd, &mount_point)?;
// Ensure that we can safely reopen `mount_point_path` with `O_RDONLY`
let file_type = st_mode & libc::S_IFMT;
if !is_safe_inode(file_type) {
return Err(self
.error_for(mount_id, io::Error::from_raw_os_error(libc::EIO))
.set_desc(format!(
"Mount point \"{mount_point}\" is not a regular file or directory"
)));
}
// Now that we know that this is a regular file or directory, really open it
let file = reopen_fd(
mount_point_fd.as_raw_fd(),
libc::O_RDONLY | libc::O_NOFOLLOW | libc::O_CLOEXEC,
st_mode,
)
.map_err(|e| {
self.error_for(mount_id, e).prefix(format!(
"Failed to reopen mount point \"{mount_point}\" for reading"
))
})?;
let mut mount_fds_locked = self.map.write().unwrap();
// As above: by calling `and_then(Weak::upgrade)`, we treat a failed upgrade just like a
// non-existent key. If the key exists but upgrade fails, then `HashMap::insert()`
// below will update the value. `MountFd::drop()` takes care to only remove a `MountFd`
// without strong references from the map, and hence will not touch the updated one.
if let Some(mount_fd) = mount_fds_locked.get(&mount_id).and_then(Weak::upgrade) {
// A mount FD was added concurrently while we did not hold a lock on
// `mount_fds.map` -- use that entry (`file` will be dropped).
mount_fd
} else {
debug!(
"Creating MountFd: mount_id={}, mount_fd={}",
mount_id,
file.as_raw_fd(),
);
let mount_fd = Arc::new(MountFd {
file,
mount_id,
map: Arc::downgrade(&self.map),
});
mount_fds_locked.insert(mount_id, Arc::downgrade(&mount_fd));
mount_fd
}
};
Ok(mount_fd)
}
// Ensure that `mount_point_path` refers to an inode with the mount ID we need
fn validate_mount_id(
&self,
mount_id: MountId,
mount_point_fd: &impl AsRawFd,
mount_point: &str,
) -> MPRResult<libc::mode_t> {
let stx = statx(mount_point_fd, None).map_err(|e| {
self.error_for(mount_id, e)
.prefix(format!("Failed to stat mount point \"{mount_point}\""))
})?;
if stx.mnt_id != mount_id {
return Err(self
.error_for(mount_id, io::Error::from_raw_os_error(libc::EIO))
.set_desc(format!(
"Mount point's ({}) mount ID ({}) does not match expected value ({})",
mount_point, stx.mnt_id, mount_id
)));
}
Ok(stx.st.st_mode)
}
/// Given a mount ID, return the mount root path (by reading `/proc/self/mountinfo`)
fn get_mount_root(&self, mount_id: MountId) -> MPRResult<String> {
let mountinfo = {
let mountinfo_file = &mut *self.mount_info.lock().unwrap();
mountinfo_file.rewind().map_err(|e| {
self.error_for_nolookup(mount_id, e)
.prefix("Failed to access /proc/self/mountinfo".into())
})?;
let mut mountinfo = String::new();
mountinfo_file.read_to_string(&mut mountinfo).map_err(|e| {
self.error_for_nolookup(mount_id, e)
.prefix("Failed to read /proc/self/mountinfo".into())
})?;
mountinfo
};
let path = mountinfo.split('\n').find_map(|line| {
let mut columns = line.split(char::is_whitespace);
if columns.next()?.parse::<MountId>().ok()? != mount_id {
return None;
}
// Skip parent mount ID, major:minor device ID, and the root within the filesystem
// (to get to the mount path)
columns.nth(3)
});
match path {
Some(p) => {
let p = String::from(p);
if let Some(prefix) = self.mount_prefix.as_ref() {
if let Some(suffix) = p.strip_prefix(prefix).filter(|s| !s.is_empty()) {
Ok(suffix.into())
} else {
// The shared directory is the mount point (strip_prefix() returned "") or
// mount is outside the shared directory, so it must be the mount the root
// directory is on
Ok("/".into())
}
} else {
Ok(p)
}
}
None => Err(self
.error_for_nolookup(mount_id, einval())
.set_desc(format!("Failed to find mount root for mount ID {mount_id}"))),
}
}
/// Generate an `MPRError` object for the given `mount_id`, and silence it if we have already
/// generated such an object for that `mount_id`.
/// (Called `..._nolookup`, because in contrast to `MountFds::error_for()`, this method will
/// not try to look up the respective mount root path, and so is safe to call when such a
/// lookup would be unwise.)
fn error_for_nolookup<E: ToString + Into<io::Error>>(
&self,
mount_id: MountId,
err: E,
) -> MPRError {
let err = MPRError::from(err).set_mount_id(mount_id);
if self.error_logged.read().unwrap().contains(&mount_id) {
err.silence()
} else {
self.error_logged.write().unwrap().insert(mount_id);
err
}
}
/// Call `self.error_for_nolookup()`, and if the `MPRError` object is not silenced, try to
/// obtain the mount root path for the given `mount_id` and add it to the error object.
/// (Note: DO NOT call this method from `MountFds::get_mount_root()`, because that may lead to
/// an infinite loop.)
pub fn error_for<E: ToString + Into<io::Error>>(&self, mount_id: MountId, err: E) -> MPRError {
let err = self.error_for_nolookup(mount_id, err);
if err.silent() {
// No need to add more information
err
} else {
// This just adds some information, so ignore errors
if let Ok(mount_root) = self.get_mount_root(mount_id) {
err.set_mount_root(mount_root)
} else {
err
}
}
}
}
/**
* Error object (to be used as `Result<T, MPRError>`) for mount-point-related errors (hence MPR).
* Includes a description (that is auto-generated from the `io::Error` at first), which can be
* overridden with `MPRError::set_desc()`, or given a prefix with `MPRError::prefix()`.
*
* The full description can be retrieved through the `Display` trait implementation (or the
* auto-derived `ToString`).
*
* `MPRError` objects should generally be logged at some point, because they may indicate an error
* in the user's configuration or a bug in virtiofsd. However, we only want to log them once per
* filesystem, and so they can be silenced (setting `silent` to true if we know that we have
* already logged an error for the respective filesystem) and then should not be logged.
*
* Naturally, a "mount-point-related" error should be associated with some mount point, which is
* reflected in `fs_mount_id` and `fs_mount_root`. Setting these values will improve the error
* description, because the `Display` implementation will prepend these values to the returned
* string.
*
* To achieve this association, `MPRError` objects should be created through
* `MountFds::error_for()`, which obtains the mount root path for the given mount ID, and will thus
* try to not only set `fs_mount_id`, but `fs_mount_root` also. `MountFds::error_for()` will also
* take care to set `silent` as appropriate.
*
* (Sometimes, though, we know an error is associated with a mount point, but we do not know with
* which one. That is why the `fs_mount_id` field is optional.)
*/
#[derive(Debug)]
pub struct MPRError {
io: io::Error,
description: String,
silent: bool,
fs_mount_id: Option<MountId>,
fs_mount_root: Option<String>,
}
/// Type alias for convenience
pub type MPRResult<T> = Result<T, MPRError>;
impl<E: ToString + Into<io::Error>> From<E> for MPRError {
/// Convert any stringifyable error object that can be converted to an `io::Error` to an
/// `MPRError`. Note that `fs_mount_id` and `fs_mount_root` are not set, so this `MPRError`
/// object is not associated with any mount point.
/// The initial description is taken from the original error object.
fn from(err: E) -> Self {
let description = err.to_string();
MPRError {
io: err.into(),
description,
silent: false,
fs_mount_id: None,
fs_mount_root: None,
}
}
}
impl MPRError {
/// Override the current description
#[must_use]
pub fn set_desc(mut self, s: String) -> Self {
self.description = s;
self
}
/// Add a prefix to the description
#[must_use]
pub fn prefix(self, s: String) -> Self {
let new_desc = format!("{}: {}", s, self.description);
self.set_desc(new_desc)
}
/// To give additional information to the user (when this error is logged), add the mount ID of
/// the filesystem associated with this error
#[must_use]
fn set_mount_id(mut self, mount_id: MountId) -> Self {
self.fs_mount_id = Some(mount_id);
self
}
/// To give additional information to the user (when this error is logged), add the mount root
/// path for the filesystem associated with this error
#[must_use]
fn set_mount_root(mut self, mount_root: String) -> Self {
self.fs_mount_root = Some(mount_root);
self
}
/// Mark this error as silent (i.e. not to be logged)
#[must_use]
fn silence(mut self) -> Self {
self.silent = true;
self
}
/// Return whether this error is silent (i.e. should not be logged)
pub fn silent(&self) -> bool {
self.silent
}
/// Return the `io::Error` from an `MPRError` and drop the rest
pub fn into_inner(self) -> io::Error {
self.io
}
}
impl std::fmt::Display for MPRError {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match (self.fs_mount_id, &self.fs_mount_root) {
(None, None) => write!(f, "{}", self.description),
(Some(id), None) => write!(f, "Filesystem with mount ID {}: {}", id, self.description),
(None, Some(root)) => write!(
f,
"Filesystem mounted on \"{}\": {}",
root, self.description
),
(Some(id), Some(root)) => write!(
f,
"Filesystem mounted on \"{}\" (mount ID: {}): {}",
root, id, self.description
),
}
}
}
impl std::error::Error for MPRError {}
#[cfg(test)]
mod tests {
use super::*;
use crate::passthrough::file_handle::FileHandle;
#[test]
fn test_mount_fd_get() {
let topdir = env!("CARGO_MANIFEST_DIR");
let dir = File::open(topdir).unwrap();
let filename = CString::new("build.rs").unwrap();
let mount_fds = MountFds::new(None).unwrap();
let handle = FileHandle::from_name_at(&dir, &filename).unwrap().unwrap();
// Ensure that `MountFds::get()` works for new entry.
let fd1 = mount_fds
.get(handle.mnt_id, |_fd, _flags, _mode| File::open(topdir))
.unwrap();
assert_eq!(Arc::strong_count(&fd1), 1);
assert_eq!(mount_fds.map.read().unwrap().len(), 1);
// Ensure that `MountFds::get()` works for existing entry.
let fd2 = mount_fds
.get(handle.mnt_id, |_fd, _flags, _mode| File::open(topdir))
.unwrap();
assert_eq!(Arc::strong_count(&fd2), 2);
assert_eq!(mount_fds.map.read().unwrap().len(), 1);
// Ensure fd1 and fd2 are the same object.
assert_eq!(fd1.as_fd().as_raw_fd(), fd2.as_fd().as_raw_fd());
drop(fd1);
assert_eq!(Arc::strong_count(&fd2), 1);
assert_eq!(mount_fds.map.read().unwrap().len(), 1);
// Ensure that `MountFd::drop()` works as expected.
drop(fd2);
assert_eq!(mount_fds.map.read().unwrap().len(), 0);
}
#[test]
fn test_mpr_error() {
let io_error = io::Error::new(io::ErrorKind::Other, "test");
let mpr_error = MPRError::from(io_error);
assert!(!mpr_error.silent);
assert!(mpr_error.fs_mount_id.is_none());
assert!(mpr_error.fs_mount_root.is_none());
let mpr_error = mpr_error.silence();
let msg = format!("{}", mpr_error);
assert!(msg.len() > 0);
assert!(mpr_error.silent());
}
}